Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.

https://hacktoberfest.digitalocean.com

Other

496 stars 147 forks source link

Fixed missed seven => fourteen day review window change #639

Closed MarkCBell closed 3 years ago

MarkCBell commented 3 years ago

PR #614 got most of the rule changes but missed one reference to the review window now being 14 days

Requirements to merge

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

MarkCBell commented 3 years ago

So it makes no difference to me since I already have four accepted PRs, but is this an example of a PR that should have also been tagged as "hacktoberfest-accepted"? It appears that @MattIPv4 agreed that this work was needed, it's just that instead of merging in this PR he repeated the work in #643. What is DO's policy on PRs that were correct and needed but have later been duplicated by another developer? Does only one get credit?

MattIPv4 commented 3 years ago

Ah shoot, yeah, forgot to label this as GH auto-closed it. Ty for the ping