As we have moved to require PRs be merged this year, instead of just created, a PR could be merged after the end of October and we would consider this, transitioning it to waiting and starting the timer.
To prevent this, a check was added to the waiting transition to ensure that Hf has not yet ended. A spec has also be added to ensure this behaviour remains correct.
Test process
Create a PR during Hacktoberfest
Merge the PR after Hacktoberfest
Ensure the PR does not transition to waiting
Requirements to merge
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Description
As we have moved to require PRs be merged this year, instead of just created, a PR could be merged after the end of October and we would consider this, transitioning it to waiting and starting the timer.
To prevent this, a check was added to the waiting transition to ensure that Hf has not yet ended. A spec has also be added to ensure this behaviour remains correct.
Test process
Requirements to merge