This PR adds a .erb lint step to the lint workflow, using the erb-lint gem. Currently I use the default configuration, which generates 1122 linter errors. I've left this PR in a draft state to get feedback on the preferred ruleset before pulling in fixes for the errors.
The default ruleset is:
Each rule can be enabled/disabled individually, so I am hoping for guidance on which rules should be applied.
Test process
I ran the lint command that I added to the lint.yml workflow file manually, and verified that it hit the intended files and yielded results. I also verified that the script/tests still worked correctly.
The commands were all run in an Ubuntu shell for the WSL service, because Windows doesn't play well with Ruby natively.
[ ] Test A
[ ] Test B
Requirements to merge
[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
Description
This PR adds a
.erblint step to thelintworkflow, using theerb-lintgem. Currently I use the default configuration, which generates 1122 linter errors. I've left this PR in a draft state to get feedback on the preferred ruleset before pulling in fixes for the errors.The default ruleset is:
Each rule can be enabled/disabled individually, so I am hoping for guidance on which rules should be applied.
Test process
I ran the lint command that I added to the
lint.ymlworkflow file manually, and verified that it hit the intended files and yielded results. I also verified that thescript/testsstill worked correctly.The commands were all run in an Ubuntu shell for the WSL service, because Windows doesn't play well with Ruby natively.
Requirements to merge