Rephrase 'PR counts logic' to match what's actually happening

[davidstosik]

Description

I started by tweeting this, but then realised it's part of a code base I can submit a PR for! 💡

I have the feeling that the logic described on the Hacktoberfest update, and on the details page does not match what is described on my profile page (quoted below), or what I am experiencing with my own PRs.

Here's what I read on my profile page (emphasis mine):

Legend

:clock4: In Review

Your PR has been accepted by a maintainer and is currently within the review period, which lasts for fourteen days.

:question: Pending

Your PR has not yet been accepted by a maintainer. A maintainer can accept your PR by merging it, adding the "hacktoberfest-accepted" label to it, or approving it.

:x: Invalid

Your PR has been labeled as "invalid" or "spam" by a maintainer and won't count toward winning Hacktoberfest.

:exclamation: Ineligible Repository

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

:white_check_mark: Accepted

Good job! Your PR has passed the review period and counts toward completing the Hacktoberfest challenge!

I assumed that the behavior described on my profile page is the intended behavior (as this is what I observe with my PRs, see below), and that the static HTML with the described logic was wrong. I might be mistaken, so please let me know.

Test process

I have 4 PRs, which I submitted before the changes to the rules (don't kno if this matters).

• The PRs have been merged.
• The PRs are not tagged with hacktoberfest-approved (at time of writing).
• The repository does not have the hacktoberfest topic (at time of writing).
• And yet, the 4 PRs are all marked as ":clock4: In Review".

Requirements to merge

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code in hard-to-understand areas
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes

[davidstosik]

Hmm, now this PR shows up on my profile, and it is marked as "pending", even though this repository has the hacktoberfest topic, which means that my rule is wrong too... 🤔

Does the hacktoberfest repo topic actually add anything to the rule system? Or does the rule change apply only to PRs submitted after it happened?

[MattIPv4]

As noted on the update page (https://hacktoberfest.digitalocean.com/hacktoberfest-update), the rules change does not apply to PRs submitted before October 3rd 12:00 UTC. This behaviour you're seeing on the profile page is correct and intended.

I don't really see much value in this PR, centralising these rules in a shared template has little benefit (avoiding duplication) and will slow down page renders.

The actual change you have made to reword the rules is incorrect and not how the app works.

[davidstosik]

@MattIPv4 Thanks for checking! Sorry for the noise. 🙇‍♂️