Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.

https://hacktoberfest.digitalocean.com

Other

496 stars 147 forks source link

fix(client/profile): add media query for `profile` #704

Closed jagnani73 closed 3 years ago

jagnani73 commented 3 years ago

Description

Fixes #703 by adding a media query for the screen size $break-small

Requirements to merge

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

jagnani73 commented 3 years ago

You've modified the FAQ styling, not the profile page?

Ahh, my bad! I'll revert changes and add the required ones ASAP!

jagnani73 commented 3 years ago

@MattIPv4 I have changed the required and reverted the prev changes. Apologies for the previous request!

jagnani73 commented 3 years ago

_waiting_for_prize.html.erb & _waiting_thank_you.html.erb need to be updated to use .is-1 instead of .thanks-text.

Please can you revert the unrelated formatting changes, so that there is a clean blame?

@MattIPv4 Now I just have to switch the mentioned classes in the files and remove the changes done by prettier in the previous commits right?

MattIPv4 commented 3 years ago

👍 yup, please

jagnani73 commented 3 years ago

Hi @MattIPv4 I have cleaned the blame and dropped the unnecessary commits!