Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Add Tooltip on Icons #709

Closed reginaalyssa closed 3 years ago

reginaalyssa commented 3 years ago

Description

Adds tooltip on hover of the icons (Invalid, Bonus, Accepted, Ineligible Repository, In Review, Pending) for the pull requests under Profile.

Closes #627

Light Mode:

Screen Shot 2020-10-21 at 8 12 55 PM

Dark Mode:

Screen Shot 2020-10-21 at 8 13 02 PM

Test process

Tests were done by manually running the server and checking if the tooltip appears on hover of the icon. Go to http://localhost:3000/profile and hover the mouse on any of the icons.

Requirements to merge

reginaalyssa commented 3 years ago

Note: I haven't added any tests for the visual change. Please let me know how to go about this.

Also I have existing unit tests failing in my local environment even before changes were made for the following tests:

Mostly due to key not found: "TEST_USER_GITHUB_TOKEN" Hope I can get your help in resolving these. Thank you!

MattIPv4 commented 3 years ago

👋 Awesome -- yeah, running the test suite locally will need TEST_USER_GITHUB_TOKEN set to a valid GitHub access token I think.

The CI on the PR here runs the test suite though and everything is passing just fine :) Will pull down and review the changes shortly!

reginaalyssa commented 3 years ago

Yay, thank you so much! 🙏