Hacktoberfest / hacktoberfest-2020

Hacktoberfest - App to manage the annual open-source challenge, used for the 2019 & 2020 seasons.
https://hacktoberfest.digitalocean.com
Other
496 stars 147 forks source link

Preserve topic repos #723

Closed MattIPv4 closed 3 years ago

MattIPv4 commented 3 years ago

Description

Create PreservedTopicPR which will contain all PR IDs that were in the waiting state prior to Hf ending.

Skip the repository topic check for a PR if it is in the preserved list.

Rake task to restore PRs back into the waiting state if they became invalid due to the topic being removed after Hf ended.

Rake task to restore users back into the correct state if their invalid PRs caused them to lose.

Test process

This is absolutely untested, good luck.

Requirements to merge

MattIPv4 commented 3 years ago

After discussion with whole dev team, we have all agreed the user transitions involved are too risky.

hpoul commented 3 years ago

does this mean it's just bad luck if the topic was removed from a repository, or is there a workaround without bothering the project admin to reapply the topic 🤔️

cy commented 3 years ago

does this mean it's just bad luck if the topic was removed from a repository, or is there a workaround without bothering the project admin to reapply the topic 🤔️

Even if the maintainer reapplies the topic, the PRs do not become invalidated, see the discussion in https://github.com/python/typeshed/issues/4631 for an example. Unfortunately, I think all of us sad about this have no workaround since #723 was closed.