search

Hacktoberfest / hacktoberfest-2022

Hacktoberfest - Site for the annual open-source challenge, used for the 2022-2024 seasons.
https://hacktoberfest.com
Other
14 stars 15 forks source link

Replace PNG sponsor assets with SVGs #70

Open MattIPv4 opened 2 months ago

MattIPv4 commented 2 months ago

Feature Suggestion

Feature description

Replace all the PNGs found in https://github.com/Hacktoberfest/hacktoberfest-2022/tree/main/src/assets/img/partners with SVG equivalents (please find SVGs from the brands themselves and note the sources in the PR, do not use a tracing tool).

How the feature is useful

Better fidelity of the assets.

Siddharthgup commented 1 month ago

Hi @MattIPv4 ,Can you assigned this task to me ?

MattIPv4 commented 1 month ago

Sure 👍

Anandprafull commented 1 month ago

@MattIPv4 Please check the PR i have replaced the assets as well as the related sponser.js code

MattIPv4 commented 1 month ago

@Anandprafull this issue was already assigned to someone else to work on...

Anandprafull commented 1 month ago

I see but since there hadn't been any update on the issue so i worked on it..

MattIPv4 commented 1 month ago

Yup, but it has only been three days since they asked for it to be assigned to them, and only a day since Hacktoberfest started. It is important to communicate on issues, especially where they are assigned to someone else, not just assume you can do it instead.

I'll leave your PR up for now, but there are issues with it that need to be addressed.

MattIPv4 commented 1 month ago

@Siddharthgup Are you intending to work on this still?

Siddharthgup commented 1 month ago

Yes,It's almost completed

Lokeshsuwalka05 commented 1 month ago

Hello,if it's still open. Can you assign this issue to me??

MattIPv4 commented 1 month ago

@Lokeshsuwalka05 as you can see from the issue itself, it is already assigned to someone else.

kingsmen732 commented 1 month ago

is this issue still open or does it need to closed? @MattIPv4 kindly assign me if its still open :)