Disallow forks and private by default, but allow by flags

Hacktoberfest / hacktoberfest-repo-topic-apply

Cmd line tool to add a topic to your github repo, defaults to hacktoberfest

Apache License 2.0

48 stars 43 forks source link

Disallow forks and private by default, but allow by flags #19

Closed halkeye closed 3 years ago

halkeye commented 3 years ago

so related to #9

Type allows different values depending on which version of docs you look at. So Simplified the checks to just be able to exclude anything you don't want.

I could default excludeForks to true, but then to disable it you'd have to use --no-excludeForks which isn't documented by --help

Let me know

MasonEgger commented 3 years ago

I think excluding forks is the way to go. If you just add the option then it'll be documented by --help automatically. I can update the README afterwards. I'm pretty sure being able to limit it to just public, non-fork non-archives (which someone already did) will be what a vast majority of people using the tool will want.

MasonEgger commented 3 years ago

Ok. After thinking about it let's default the tool to just do public repos. Instead of doing an exclude could we do --include-forks --include-private so these can be regular flags and then we'll document in the readme a --no-include-public that will serve if you want to remove the public option (I feel this will be a very low use case)

halkeye commented 3 years ago

I havn't fully tested this as I don't want to start messing with labels everwhere and making it dry run is a bit of effort, but I can do more extensive testing tonight.

Might want to enable ignore whitespace to review this

Switched exclude => include and deleted the non forks and public options
Added a shared logger statement so every log line has repo name
Bail out of archived and disabled early (which is why so many whitespace lines changed)

halkeye commented 3 years ago

Okay tested by adding a dryrun, looks good