search

Hackwar / jlrouter

GNU General Public License v3.0
8 stars 1 forks source link

Conflict with AMP extention #3

Closed ch2856 closed 7 years ago

ch2856 commented 7 years ago

Hi Hannes. It's been a long 3 years :-)

I was testing the router and there is a conflict with AMP extension (google accelerated pages) from weeblr.com (same guys of sh404sef). If AMP is enabled I am getting 500 error. Maybe you should talk with them to understand where the conflict is.

Thanks, Ram

Hackwar commented 7 years ago

Can you make sure that the jlrouter plugin is the first in ordering? If that does not solve the issue, I will contact them.

Hackwar commented 7 years ago

I found the issue. The wbamp extension loads the router even earlier than my plugin does and thus my plugin can't override the class. I will provide an update. It still requires to make sure that this plugin is first in calling order.

ch2856 commented 7 years ago

Thanks,

I am still not in front of my PC (tested on a local server) so I couldn't check it out. By the way, from the short time I have tested it, it works just fine. I believe J team was wrong for not implanting it on 3.7. It's time for joomla to move on from past mistakes.

Hackwar commented 7 years ago

The issue is fixed in the repo. I will deploy a new version with another feature soon. 😄

ch2856 commented 7 years ago

I am reopening it since now, the ID is not removed from article URL.