search

Hadiasemi / Crypto-Tracker

0 stars 2 forks source link

Edit get_history to work with coin ID #52

Closed WeslyOrtega closed 3 years ago

WeslyOrtega commented 3 years ago

get_history only works with a coin's name.

Edit the function so that it also works with a coin's ID.

Time estimate: 1 Hour

WeslyOrtega commented 3 years ago

The history of a coin is acquired through a request to coincap's API and it only accepts a coin's name. A more general request could be made in order to get the coin that matches the given symbol but it would be very inefficient and introduce unnecessary overhead. It is better to just make sure that it only receives the name of the coin.