search

Hadiasemi / Crypto-Tracker

0 stars 2 forks source link

Model Testing #73

Closed WeslyOrtega closed 3 years ago

WeslyOrtega commented 3 years ago

Created extensive testing to both the User model and Crypto model. Also reformatted the previous tests.

Closes #69

Time Spent: 2 Hours

WeslyOrtega commented 3 years ago

Approved and looks good, but I did have some questions regarding pytest. Does it provide some kind of mocking of functions and/or db models? It seems like the current tests access the actual DB and I was wondering if it would be appropriate to have a separate document in mongoDB for testing or just mock the database access entirely?

I believe there is another pytest library that can mock up databases, but I'm not sure if it is compatible with MongoDB.

I think it should be fine as it is right now since it's only altering a test user and not creating any new ones, but we can look into it if we wanted to do an extensive test of the entire backend in the future.

jinyung2 commented 3 years ago

I think extensions on testing are unnecessary at this point in the project but if we wanted to continue working on the app in the future that would be a possibility. New changes look good!