[RUN-5625] Propagate events from BrowserView to Application and System - Githubissues

HadoukenIO / core

Hadouken is an open-source platform for creating web applications with native desktop experience. Hadouken is the base project used to build OpenFin OS, a desktop operating layer used by 45+ major banks, buy-side and vendors to deploy hundreds of apps to over 400 financial firms.

http://hadouken.io/

Other

103 stars 50 forks source link

[RUN-5625] Propagate events from BrowserView to Application and System #960

Closed MichaelMCoates closed 5 years ago

MichaelMCoates commented 5 years ago

Description of Change

Sets up event propagation from BrowserView up to Application and System.

Tests: https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5d88dfaf7ba87401eaf565df

Checklist

[X] PR description included and stakeholders cc'd
[X] npm test passes
[X] automated tests are changed or added
[ ] manual tests are changed or added
[X] relevant documentation is changed or added
[X] PR title starts with the JIRA ticket pull request process
[X] PR release notes describe the change in a way relevant to app-developers
[X] Link to new tests added
[X] PR has assigned reviewers

Release Notes

Notes:

BrowserView events now propagate up to Application and System.

openfin-github-bot[bot] commented 5 years ago

628621a

Git

core: develop <= dev/coates/RUN-5625 (628621a)
js-adapter: develop
javascript-adapter: develop
Asars used for testing
app.asar
adapter.asar
Test results
:white_check_mark: Windows 10 (32-bit runtime): Failed 0/665
:white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
:white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
:white_check_mark: Windows 10 (64-bit runtime): Failed 0/665

MichaelMCoates commented 5 years ago

Tests are missing awaits on several view.hide()s other than that looks good.

Good catch, updated and re-run: https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5d89022f7ba87401eaf565ff