Bugfix - Call removeBrowserView on oldWin so that we can attach BrowserViews back and forth

HadoukenIO / core

Hadouken is an open-source platform for creating web applications with native desktop experience. Hadouken is the base project used to build OpenFin OS, a desktop operating layer used by 45+ major banks, buy-side and vendors to deploy hundreds of apps to over 400 financial firms.

http://hadouken.io/

Other

103 stars 50 forks source link

Bugfix - Call removeBrowserView on oldWin so that we can attach BrowserViews back and forth #970

Closed MichaelMCoates closed 5 years ago

MichaelMCoates commented 5 years ago

Description of Change

Fixes a bug that prevents a BrowserView from attaching back to the window it was originally attached to.

Bug Repro:

Create a BrowserView on Window A.
Attach the BV to Window B.
Attempt to attach the BV back to Window A. Expected: BV Shows up on Window A. Actual: BV stays on Window B.

To fix, we simply call removeBrowserView with the old window.

Checklist

[X] PR description included and stakeholders cc'd
[X] npm test passes)
[X] PR has assigned reviewers

Release Notes

Notes:

openfin-github-bot[bot] commented 5 years ago

dad88d5

Git

core: develop <= dev/coates/removeBrowserView-fix (dad88d5)
js-adapter: develop
javascript-adapter: develop
Asars used for testing
app.asar
adapter.asar
Test results
:white_check_mark: Windows 7 (32-bit runtime): Failed 0/665
:white_check_mark: Windows 10 (32-bit runtime): Failed 0/665
:white_check_mark: Windows 7 (64-bit runtime): Failed 0/665
:white_check_mark: Windows 10 (64-bit runtime): Failed 0/665

pbaize commented 5 years ago

Let's also move the target check above this section