RUN-5674 | BrowserView creates multiply window/close events if attached is called more than once

HadoukenIO / core

Hadouken is an open-source platform for creating web applications with native desktop experience. Hadouken is the base project used to build OpenFin OS, a desktop operating layer used by 45+ major banks, buy-side and vendors to deploy hundreds of apps to over 400 financial firms.

http://hadouken.io/

Other

103 stars 50 forks source link

RUN-5674 | BrowserView creates multiply window/close events if attached is called more than once #979

Closed tomer-openfin closed 5 years ago

tomer-openfin commented 5 years ago

Description of Change

Don't append close event handler in case it already exists.

Checklist

[x] PR description included and stakeholders cc'd
[x] npm test passes
[x] PR title starts with the JIRA ticket pull request process
[x] PR has assigned reviewers

openfin-github-bot[bot] commented 5 years ago

c2fe001

Git

core: develop <= bv_fix (c2fe001)
js-adapter: develop
javascript-adapter: develop
Asars used for testing
app.asar
adapter.asar
Test results
:scream: Windows 10 (32-bit runtime): Failed 10/665
:cold_sweat: Windows 7 (32-bit runtime): Failed 1/665
:scream: Windows 10 (64-bit runtime): Failed 10/665
:cold_sweat: Windows 7 (64-bit runtime): Failed 1/665

HadoukenIO / core

RUN-5674 | BrowserView creates multiply window/close events if attached is called more than once #979

Description of Change

Checklist

Git

Asars used for testing

Test results