HadrienG / InSilicoSeq

:rocket: A sequencing simulator
https://insilicoseq.readthedocs.io
MIT License
176 stars 32 forks source link

Remove Unused Dependency: Future #238

Closed gdrosos closed 9 months ago

gdrosos commented 10 months ago

Summary

This pull request removes the unused dependency future from the setup.py, Pipfile and Pipfile.lockconfiguration files. The removal of this dependency is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The future library was originally introduced to the project to bridge compatibility between Python 2 and Python 3, as per b9f6035. However, as evident from ed6a204, the project decided to drop support for Python 2, rendering the future library superfluous. Despite this change in the codebase, future continued to be listed in the project's dependency files. Removing this unused dependency reduces the overall footprint of the application, mitigating potential security risks, and simplifying the dependency management process.

Changes

Impact

HadrienG commented 10 months ago

Hi,

Thanks for catching that!

/Hadrien

gdrosos commented 10 months ago

Hello @HadrienG, I'm glad you found the changes helpful! Just wanted to check if there are any additional steps or revisions needed from my end to move this PR forward? Thanks!