HadrienG / InSilicoSeq

:rocket: A sequencing simulator
https://insilicoseq.readthedocs.io
MIT License
181 stars 32 forks source link

add iss download command #39

Closed jhayer closed 5 years ago

jhayer commented 6 years ago

The idea would be to have a specific command for downloading genomes from NCBI

HadrienG commented 6 years ago

It sound like a good idea, but I'm reluctant to implement it now since the --ncbi option is rather slow (especially for viruses and archaea) and should not be the preferred way of running InSilicoSeq at the moment.

I'm inclined to put this on hold while I haven't found a more efficient way to download random genomes. As it is now the functionality is not good enough to warrant its own subcommand.

HadrienG commented 5 years ago

@jhayer I've sped up the ncbi downloads. Do you still think it is a good idea? What would be your use case for this?

jhayer commented 5 years ago

Yes I would use it to make simulated viral metagenomics datasets from random viruses. So I do not spend time choosing and collecting genomes. Great that you managed to speed up the dl :-)

HadrienG commented 5 years ago

I'm closing this per our phone discussion, since iss generate --ncbi downloads and save the downloaded genomes already