search

HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
24 stars 6 forks source link

Fix lints in nightly CI #105

Closed HadrienG2 closed 10 months ago

HadrienG2 commented 10 months ago

Technically, one of the "fixes" is actually a workaround for a clippy false positive. But I actually like the workaround version better.

Along the way, this also fixes a trait bound bug where the "external" PartialEq impl of XML did not work because I expressed it in terms of str, when string comparison traits are actually implemented for &str.

semanticdiff-com[bot] commented 10 months ago

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Overall, the semantic diff is 49% smaller than the GitHub diff.

Filename Status
:heavy_check_mark: src/lib.rs 77.84% smaller
:heavy_check_mark: src/topology/export/xml.rs 35.53% smaller
codecov[bot] commented 10 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9ad1103) 65.28% compared to head (8bfd315) 65.28%.

Files Patch % Lines
src/topology/export/xml.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #105 +/- ## ======================================= Coverage 65.28% 65.28% ======================================= Files 43 43 Lines 4632 4632 ======================================= Hits 3024 3024 Misses 1608 1608 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/105/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/105/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `66.53% <0.00%> (ø)` | | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/105/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `63.90% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.