Closed HadrienG2 closed 7 months ago
Review changes with SemanticDiff.
Analyzed 2 of 2 files.
Overall, the semantic diff is 49% smaller than the GitHub diff.
Filename | Status | |
---|---|---|
:heavy_check_mark: | src/lib.rs | 77.84% smaller |
:heavy_check_mark: | src/topology/export/xml.rs | 35.53% smaller |
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
9ad1103
) 65.28% compared to head (8bfd315
) 65.28%.
Files | Patch % | Lines |
---|---|---|
src/topology/export/xml.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Technically, one of the "fixes" is actually a workaround for a clippy false positive. But I actually like the workaround version better.
Along the way, this also fixes a trait bound bug where the "external" PartialEq impl of XML did not work because I expressed it in terms of
str
, when string comparison traits are actually implemented for&str
.