search

HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Add tests for topology editing + smaller fixes #107

Closed HadrienG2 closed 7 months ago

semanticdiff-com[bot] commented 7 months ago

Review changes with SemanticDiff.

Analyzed 18 of 21 files.

Overall, the semantic diff is 12% smaller than the GitHub diff.

File Information | | Filename | Status | | --- | :--- | :--- | | :grey_question: | \.github/workflows/ci\.yml | Unsupported file format | | :grey_question: | \.gitignore | Unsupported file format | | :grey_question: | Cargo\.toml | Unsupported file format | | :heavy_check_mark: | [src/bitmap/newtypes\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/bitmap/newtypes.rs) | 82.41% smaller | | :heavy_check_mark: | [src/cpu/kind\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/cpu/kind.rs) | 25.08% smaller | | :heavy_check_mark: | [src/errors\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/errors.rs) | Analyzed | | :heavy_check_mark: | [src/ffi/string\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/ffi/string.rs) | 27.78% smaller | | :heavy_check_mark: | [src/lib\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/lib.rs) | Analyzed | | :heavy_check_mark: | [src/memory/attribute\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/memory/attribute.rs) | 30.51% smaller | | :heavy_check_mark: | [src/memory/binding\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/memory/binding.rs) | 57.4% smaller | | :heavy_check_mark: | [src/object/attributes/cache\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/attributes/cache.rs) | 33.9% smaller | | :heavy_check_mark: | [src/object/attributes/group\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/attributes/group.rs) | 10.31% smaller | | :heavy_check_mark: | [src/object/distance\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/distance.rs) | 13.81% smaller | | :heavy_check_mark: | [src/object/hierarchy\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/hierarchy.rs) | 3.45% smaller | | :heavy_check_mark: | [src/object/lists\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/lists.rs) | Analyzed | | :heavy_check_mark: | [src/object/mod\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/mod.rs) | 7.4% smaller | | :heavy_check_mark: | [src/object/types\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/object/types.rs) | 74.01% smaller | | :heavy_check_mark: | [src/topology/builder\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/topology/builder.rs) | 8.8% smaller | | :heavy_check_mark: | [src/topology/editor\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/topology/editor.rs) | 3.45% smaller | | :heavy_check_mark: | [src/topology/export/xml\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/topology/export/xml.rs) | 63.24% smaller | | :heavy_check_mark: | [src/topology/mod\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/107/#src/topology/mod.rs) | 2.96% smaller |
codecov[bot] commented 7 months ago

Codecov Report

Attention: 127 lines in your changes are missing coverage. Please review.

Comparison is base (b21eef0) 65.42% compared to head (e7e37eb) 72.39%.

Files Patch % Lines
src/memory/attribute.rs 57.48% 71 Missing :warning:
src/cpu/kind.rs 31.57% 13 Missing :warning:
src/object/distance.rs 14.28% 12 Missing :warning:
src/topology/editor.rs 92.59% 10 Missing :warning:
src/topology/mod.rs 89.15% 9 Missing :warning:
src/memory/binding.rs 0.00% 8 Missing :warning:
src/topology/builder.rs 80.00% 2 Missing :warning:
src/errors.rs 75.00% 1 Missing :warning:
src/topology/export/xml.rs 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #107 +/- ## ========================================== + Coverage 65.42% 72.39% +6.96% ========================================== Files 43 43 Lines 4622 4981 +359 ========================================== + Hits 3024 3606 +582 + Misses 1598 1375 -223 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/107/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/107/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `72.01% <63.81%> (+5.31%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/107/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `70.77% <70.55%> (+6.74%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.