HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Use a simpler HTTP client library for vendored build #112

Closed HadrienG2 closed 6 months ago

HadrienG2 commented 6 months ago

Vendored build currently use reqwest for hwloc tarball downloads, which comes with the entire circus of async dependencies. By using a simpler HTTP client, the dependency count can be cut in half and the vendored build time can be reduced a little bit (-10% on my machine).

semanticdiff-com[bot] commented 6 months ago

Review changes with SemanticDiff.

Analyzed 1 of 2 files.

Overall, the semantic diff is 46% smaller than the GitHub diff.

Filename Status
:grey_question: hwlocality-sys/Cargo.toml Unsupported file format
:heavy_check_mark: hwlocality-sys/build.rs 45.45% smaller
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0835c23) 72.88% compared to head (4cd7bd8) 73.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## ========================================== + Coverage 72.88% 73.19% +0.31% ========================================== Files 42 43 +1 Lines 4399 4981 +582 ========================================== + Hits 3206 3646 +440 - Misses 1193 1335 +142 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/112/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `72.85% <ø> (-0.03%)` | :arrow_down: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `71.56% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.