HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Fix redundant imports lint from nightly rustc #113

Closed HadrienG2 closed 6 months ago

semanticdiff-com[bot] commented 6 months ago

Review changes with SemanticDiff.

Analyzed 21 of 21 files.

Overall, the semantic diff is 84% smaller than the GitHub diff.

File Information | | Filename | Status | | --- | :--- | :--- | | :heavy_check_mark: | [hwlocality\-sys/src/lib\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#hwlocality-sys/src/lib.rs) | 5.88% smaller | | :heavy_check_mark: | [src/bitmap/mod\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/bitmap/mod.rs) | 76.32% smaller | | :heavy_check_mark: | [src/bitmap/newtypes\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/bitmap/newtypes.rs) | 90.46% smaller | | :heavy_check_mark: | [src/bitmap/reference\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/bitmap/reference.rs) | 88.87% smaller | | :heavy_check_mark: | [src/ffi/int\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/ffi/int.rs) | 48.66% smaller | | :heavy_check_mark: | [src/ffi/mod\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/ffi/mod.rs) | 94.07% smaller | | :heavy_check_mark: | [src/info\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/info.rs) | 88.84% smaller | | :heavy_check_mark: | [src/object/attributes/bridge\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/bridge.rs) | 77.53% smaller | | :heavy_check_mark: | [src/object/attributes/cache\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/cache.rs) | 69.28% smaller | | :heavy_check_mark: | [src/object/attributes/group\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/group.rs) | 77.53% smaller | | :heavy_check_mark: | [src/object/attributes/mod\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/mod.rs) | 98.2% smaller | | :heavy_check_mark: | [src/object/attributes/numa\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/numa.rs) | 94.02% smaller | | :heavy_check_mark: | [src/object/attributes/osdev\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/osdev.rs) | 77.53% smaller | | :heavy_check_mark: | [src/object/attributes/pci\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/attributes/pci.rs) | 98.2% smaller | | :heavy_check_mark: | [src/object/depth\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/depth.rs) | 98.45% smaller | | :heavy_check_mark: | [src/object/hierarchy\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/hierarchy.rs) | 4.55% smaller | | :heavy_check_mark: | [src/object/types\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/object/types.rs) | 92.98% smaller | | :heavy_check_mark: | [src/topology/builder\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/topology/builder.rs) | 96.39% smaller | | :heavy_check_mark: | [src/topology/editor\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/topology/editor.rs) | Analyzed | | :heavy_check_mark: | [src/topology/mod\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/topology/mod.rs) | 84.11% smaller | | :heavy_check_mark: | [src/topology/support\.rs](https://app.semanticdiff.com/HadrienG2/hwlocality/pull/113/#src/topology/support.rs) | 94.02% smaller |
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f35b4fd) 73.19% compared to head (9aa301d) 73.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================== - Coverage 73.19% 73.15% -0.05% ========================================== Files 43 43 Lines 4981 4981 ========================================== - Hits 3646 3644 -2 - Misses 1335 1337 +2 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/113/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `72.88% <ø> (ø)` | | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `71.51% <ø> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.