search

HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Add tests for CPU binding #120

Closed HadrienG2 closed 6 months ago

HadrienG2 commented 6 months ago

One more module towards #110 :)

semanticdiff-com[bot] commented 6 months ago

Review changes with SemanticDiff.

Analyzed 5 of 7 files.

Overall, the semantic diff is 5% smaller than the GitHub diff.

Filename Status
:grey_question: .github/workflows/ci.yml Unsupported file format
:grey_question: Cargo.toml Unsupported file format
:heavy_check_mark: src/bitmap/mod.rs Analyzed
:heavy_check_mark: src/cpu/binding.rs 10.64% smaller
:heavy_check_mark: src/ffi/transparent.rs 45.29% smaller
:heavy_check_mark: src/lib.rs 62.04% smaller
:heavy_check_mark: tests/single-threaded.rs Analyzed
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.85%. Comparing base (4e5fe37) to head (20b3537).

Files Patch % Lines
src/cpu/binding.rs 94.44% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## ========================================== + Coverage 73.07% 75.85% +2.77% ========================================== Files 43 43 Lines 4988 4999 +11 ========================================== + Hits 3645 3792 +147 + Misses 1343 1207 -136 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/120/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `74.79% <77.77%> (+2.00%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `74.23% <94.73%> (+2.67%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.