HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
24 stars 6 forks source link

Fix nightly lints, clarify lifetime names #153

Closed HadrienG2 closed 2 months ago

semanticdiff-com[bot] commented 2 months ago

Review changes with SemanticDiff.

Analyzed 6 of 6 files.

Overall, the semantic diff is 65% smaller than the GitHub diff.

Filename Status
:heavy_check_mark: src/topology/editor.rs Analyzed
:heavy_check_mark: src/topology/mod.rs Analyzed
:heavy_check_mark: src/object/hierarchy.rs 0.0% smaller
:heavy_check_mark: src/object/search/mod.rs 83.77% smaller
:heavy_check_mark: src/cpu/cpuset.rs 1.55% smaller
:heavy_check_mark: hwlocality-sys/src/lib.rs 71.86% smaller
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.95%. Comparing base (1680c0c) to head (3e848fc). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #153 +/- ## ========================================== - Coverage 84.62% 82.95% -1.68% ========================================== Files 44 44 Lines 5146 5133 -13 ========================================== - Hits 4355 4258 -97 - Misses 791 875 +84 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/153/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/153/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `77.86% <100.00%> (-0.14%)` | :arrow_down: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/153/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `77.26% <90.90%> (-2.54%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.