codecov[bot]
commented
1 year ago Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
53fc8fa) 39.39% compared to head (764201e) 39.91%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #40 +/- ## ========================================== + Coverage 39.39% 39.91% +0.51% ========================================== Files 30 30 Lines 4061 4096 +35 ========================================== + Hits 1600 1635 +35 Misses 2461 2461 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `40.11% <100.00%> (+0.51%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `37.89% <94.59%> (+0.51%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [hwlocality-sys/src/lib.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-aHdsb2NhbGl0eS1zeXMvc3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | | | [src/bitmap.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2JpdG1hcC5ycw==) | `100.00% <100.00%> (ø)` | | | [src/errors.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2Vycm9ycy5ycw==) | `100.00% <ø> (ø)` | | | [src/ffi/int.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2ZmaS9pbnQucnM=) | `100.00% <ø> (ø)` | | | [src/info.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2luZm8ucnM=) | `100.00% <ø> (ø)` | | | [src/object/mod.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC9tb2QucnM=) | `8.47% <ø> (ø)` | | | [src/path.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3BhdGgucnM=) | `100.00% <ø> (ø)` | | | [src/topology/builder.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L2J1aWxkZXIucnM=) | `9.55% <100.00%> (ø)` | | | [src/topology/support.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/40?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L3N1cHBvcnQucnM=) | `10.30% <ø> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So far, I do not check that types keep implementing relevant traits, which is important for future semver compatibility. Add such checks, and fix a few inconsistencies in trait implementations along the way.