HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Tighten trait tests #52

Closed HadrienG2 closed 11 months ago

HadrienG2 commented 11 months ago

It's important to also check (to some degree) which traits we're not implementing, as adding implementations and removing them later on would break semver.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (db9fe1d) 50.23% compared to head (ecb1698) 50.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #52 +/- ## ========================================== + Coverage 50.23% 50.33% +0.10% ========================================== Files 30 30 Lines 4332 4341 +9 ========================================== + Hits 2176 2185 +9 Misses 2156 2156 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `50.52% <100.00%> (+0.10%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `50.24% <100.00%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [hwlocality-sys/src/lib.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-aHdsb2NhbGl0eS1zeXMvc3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | | | [src/bitmap.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2JpdG1hcC5ycw==) | `100.00% <100.00%> (ø)` | | | [src/errors.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2Vycm9ycy5ycw==) | `100.00% <ø> (ø)` | | | [src/ffi/int.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2ZmaS9pbnQucnM=) | `100.00% <ø> (ø)` | | | [src/info.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2luZm8ucnM=) | `100.00% <ø> (ø)` | | | [src/path.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3BhdGgucnM=) | `100.00% <ø> (ø)` | | | [src/topology/builder.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L2J1aWxkZXIucnM=) | `79.55% <100.00%> (+0.22%)` | :arrow_up: | | [src/topology/mod.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L21vZC5ycw==) | `90.00% <100.00%> (+0.12%)` | :arrow_up: | | [src/topology/support.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L3N1cHBvcnQucnM=) | `97.93% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.