HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Use into for most decaying conversions #55

Closed HadrienG2 closed 11 months ago

HadrienG2 commented 11 months ago

Per Rust API guidelines, conversions that decrease the level of abstraction should usually have a name that starts with into.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1754d2b) 50.82% compared to head (4659405) 50.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #55 +/- ## ========================================== + Coverage 50.82% 50.83% +0.01% ========================================== Files 30 30 Lines 4356 4357 +1 ========================================== + Hits 2214 2215 +1 Misses 2142 2142 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `51.02% <80.00%> (+0.01%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `50.75% <80.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [src/object/depth.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC9kZXB0aC5ycw==) | `100.00% <100.00%> (ø)` | | | [src/object/mod.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC9tb2QucnM=) | `19.26% <100.00%> (ø)` | | | [src/object/types.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC90eXBlcy5ycw==) | `55.81% <100.00%> (+1.05%)` | :arrow_up: | | [src/object/distance.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC9kaXN0YW5jZS5ycw==) | `7.84% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.