HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Switch from quickcheck to proptest #62

Closed HadrienG2 closed 11 months ago

HadrienG2 commented 11 months ago

quickcheck has some annoying bugs (e.g. inefficient shrinking implementation causes stack overflows) and is relatively unmaintained these days. I think proptest is the best available replacement at this point in time.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (496b248) 56.85% compared to head (d363527) 54.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #62 +/- ## ========================================== - Coverage 56.85% 54.71% -2.14% ========================================== Files 30 30 Lines 4601 4461 -140 ========================================== - Hits 2616 2441 -175 - Misses 1985 2020 +35 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `55.52% <86.81%> (-1.52%)` | :arrow_down: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `54.22% <84.39%> (-2.44%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [src/bitmap.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2JpdG1hcC5ycw==) | `99.83% <ø> (-0.17%)` | :arrow_down: | | [src/errors.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2Vycm9ycy5ycw==) | `100.00% <ø> (ø)` | | | [src/ffi/int.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2ZmaS9pbnQucnM=) | `98.35% <ø> (-1.65%)` | :arrow_down: | | [src/info.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL2luZm8ucnM=) | `100.00% <ø> (ø)` | | | [src/object/attributes.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC9hdHRyaWJ1dGVzLnJz) | `99.66% <100.00%> (-0.34%)` | :arrow_down: | | [src/object/depth.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC9kZXB0aC5ycw==) | `96.55% <100.00%> (-3.45%)` | :arrow_down: | | [src/object/types.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL29iamVjdC90eXBlcy5ycw==) | `100.00% <100.00%> (ø)` | | | [src/path.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3BhdGgucnM=) | `71.42% <ø> (-28.58%)` | :arrow_down: | | [src/topology/builder.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L2J1aWxkZXIucnM=) | `79.55% <100.00%> (ø)` | | | [src/topology/mod.rs](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#diff-c3JjL3RvcG9sb2d5L21vZC5ycw==) | `97.09% <100.00%> (+0.64%)` | :arrow_up: | | ... and [10 more](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/62/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.