Closed nazar-pc closed 11 months ago
Review changes with SemanticDiff.
Analyzed 1 of 2 files.
Filename | Status | |
---|---|---|
:grey_question: | hwlocality-sys/Cargo.toml | Unsupported file format |
:heavy_check_mark: | hwlocality-sys/build.rs | Analyzed |
Let me know if I should do a version bump here
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e6908e3
) 65.81% compared to head (bc0989d
) 66.97%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please bump the patch version if you want a tag right now, otherwise I'll bundle this up with other updates.
Tag is up!
Linking to framework was easy (even though I'm not sure if that is recommended way, I know there is also a way to specify attribute like
#[link(name = "CoreFoundation", kind = "framework")]
.For libxml2 something is messed up. I tried installing and using it via brew, but that didn't seem to work. No idea if libxml2 is guaranteed to exist on every macOS installation, but it definitely works at least on some systems.
My understanding is that either autotools integration is incomplete that requires these additional steps or C libraries are a pain to deal with in general, also both can be true at the same time.
Either way, it seems to work and pass CI.
Fixes https://github.com/HadrienG2/hwlocality/issues/31