HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Build static library on macOS #90

Closed nazar-pc closed 8 months ago

nazar-pc commented 8 months ago

Linking to framework was easy (even though I'm not sure if that is recommended way, I know there is also a way to specify attribute like #[link(name = "CoreFoundation", kind = "framework")].

For libxml2 something is messed up. I tried installing and using it via brew, but that didn't seem to work. No idea if libxml2 is guaranteed to exist on every macOS installation, but it definitely works at least on some systems.

My understanding is that either autotools integration is incomplete that requires these additional steps or C libraries are a pain to deal with in general, also both can be true at the same time.

Either way, it seems to work and pass CI.

Fixes https://github.com/HadrienG2/hwlocality/issues/31

semanticdiff-com[bot] commented 8 months ago

Review changes with SemanticDiff.

Analyzed 1 of 2 files.

Filename Status
:grey_question: hwlocality-sys/Cargo.toml Unsupported file format
:heavy_check_mark: hwlocality-sys/build.rs Analyzed
nazar-pc commented 8 months ago

Let me know if I should do a version bump here

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e6908e3) 65.81% compared to head (bc0989d) 66.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #90 +/- ## ========================================== + Coverage 65.81% 66.97% +1.16% ========================================== Files 43 42 -1 Lines 4599 4055 -544 ========================================== - Hits 3027 2716 -311 + Misses 1572 1339 -233 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/90/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `66.97% <ø> (ø)` | | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HadrienG2 commented 8 months ago

Please bump the patch version if you want a tag right now, otherwise I'll bundle this up with other updates.

HadrienG2 commented 8 months ago

Tag is up!