search

HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Improve interoperability of ThreadId and ProcessId with std equivalents #92

Closed HadrienG2 closed 8 months ago

HadrienG2 commented 8 months ago

Fixes #83

semanticdiff-com[bot] commented 8 months ago

Review changes with SemanticDiff.

Analyzed 6 of 7 files.

Overall, the semantic diff is 34% smaller than the GitHub diff.

Filename Status
:grey_question: Cargo.toml Unsupported file format
:heavy_check_mark: examples/bind_process_cpu.rs 8.9% smaller
:heavy_check_mark: examples/bind_threads_cpu.rs 8.85% smaller
:heavy_check_mark: src/cpu/binding.rs 58.53% smaller
:heavy_check_mark: src/lib.rs 3.01% smaller
:heavy_check_mark: src/memory/binding.rs 59.46% smaller
:heavy_check_mark: src/topology/builder.rs 24.54% smaller
codecov[bot] commented 8 months ago

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (24c26fc) 65.81% compared to head (053e0ad) 65.28%.

Files Patch % Lines
src/memory/binding.rs 0.00% 18 Missing :warning:
src/cpu/binding.rs 0.00% 15 Missing :warning:
src/lib.rs 66.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #92 +/- ## ========================================== - Coverage 65.81% 65.28% -0.54% ========================================== Files 43 43 Lines 4599 4632 +33 ========================================== - Hits 3027 3024 -3 - Misses 1572 1608 +36 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/92/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/92/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `66.63% <33.33%> (-0.45%)` | :arrow_down: | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/92/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `63.90% <7.14%> (-1.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.