search

HadrienG2 / hwlocality

Rust bindings to Open MPI Portable Hardware Locality "hwloc" library, covering version 2.0 and above.
MIT License
20 stars 5 forks source link

Use official hwloc source tarballs for vendored builds, with checksums #97

Closed HadrienG2 closed 8 months ago

HadrienG2 commented 8 months ago

Fixes #89 by replacing git branch cloning with a checksummed official hwloc tarball.

This comes at the cost of adding several heavy dependencies, and thus cold vendored builds getting much slower. But since configure scripts are slow, these builds have never been the preferred option from a performance perspective to begin with, so I guess this is a reasonable tradeoff...

semanticdiff-com[bot] commented 8 months ago

Review changes with SemanticDiff.

Analyzed 1 of 3 files.

Overall, the semantic diff is 16% smaller than the GitHub diff.

Filename Status
:grey_question: Cargo.toml Unsupported file format
:grey_question: hwlocality-sys/Cargo.toml Unsupported file format
:heavy_check_mark: hwlocality-sys/build.rs 15.22% smaller
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (14dc251) 65.28% compared to head (f6e9818) 65.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #97 +/- ## ======================================= Coverage 65.28% 65.28% ======================================= Files 43 43 Lines 4632 4632 ======================================= Hits 3024 3024 Misses 1608 1608 ``` | [Flag](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/97/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | Coverage Δ | | |---|---|---| | [ubuntu-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/97/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `66.53% <ø> (ø)` | | | [windows-latest](https://app.codecov.io/gh/HadrienG2/hwlocality/pull/97/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.) | `63.94% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Hadrien+G.#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.