search

Hadron / carthage-aws

AWS Plugin for Carthage
Other
2 stars 2 forks source link

Deployment #16

Closed hartmans closed 7 months ago

hartmans commented 7 months ago

This is still rough, and definitely not feature complete, but is ready for initial review.

hartmans commented 7 months ago

"Nick" == Nick Lang @.***> writes:

Do we need to have anything to account for when the resource_factory_method is NotImplemented?

I see you are calling self.mob = resource_factory(self.id) That's in the find_from_id method in AwsManaged, but note that AwsNatGateway overrides find_from_id and never calls super() nor accesses resource_factory_method.

This is one of those cases where I'm technically violating Liskov's Substitution Principle in that AwsNatGateway doesn't really have a resource_factory_method, and yet it all works out.

hartmans commented 7 months ago

This cannot merge until after the deployment branch on Carthage core merges.