search

Hadron / carthage-aws

AWS Plugin for Carthage
Other
2 stars 2 forks source link

Add a Makefile to make pylinting easier. #23

Closed fxdgear closed 8 months ago

fxdgear commented 8 months ago

Also, Fix a couple pylint errors.

  1. ignore pointless statement, it's not pointless cause these lines populate a memoprop.
  2. Move None to the right spot

closes #21

fxdgear commented 8 months ago

Ok I've added docs to the readme to address a few ways to install dependencies.

  1. can install things using poetry and it's virtualenv.
  2. can install things using pip with --break-system-packages
  3. can install OS managed packages

Addressed the way pylint is run in the pre-commit hook. It'll first check to see if pytlint is installed on the path. If you're in a venv it'll get installed with the dev requirements. If you're installing system level packages it was addressed to install pylint there. If pylint isn't found then it'll default to using the container.

I added docs on how to install the githooks.

I also added docs on how to run the tests either locally or in a container.