Hadron / carthage-aws

AWS Plugin for Carthage
Other
2 stars 2 forks source link

Provide way to turn off public address for dynamic network configs #26

Closed hartmans closed 5 months ago

hartmans commented 5 months ago

In 7071cf9ecb35 we added support for dynamically inferring the v4_config of a network we find by name. The main thing we populate in the v4_config is network. However there is no way to use this logic to dynamically infer the network setting while for example setting public_address to False or similar.

In the code path where we infer a v4_config, support an existing v4_config and fill in the network. (If the network is filled in, we will use a different code path and find/create the network based on its cidr and VPC).