search

Hadron / carthage-aws

AWS Plugin for Carthage
Other
2 stars 2 forks source link

AwsHostedZone delegate_zone uses only first dns record #5

Closed hartmans closed 2 years ago

hartmans commented 2 years ago

I see a couple issues with AwsHostedZone.delegate_zone. The biggest is that it appears to only use the first ns record from the delegation set. The second is that it calls the boto client directly rather than using update_record on the parent zone. Fixing both of this issues probably requires update_record to take a list (optionally?) for the values.

srak289 commented 2 years ago

I thought that the changebatch statement in delegate_zone contained all of the NS records from the delegation set. It is written with the assumption that you will always get four nameservers and be able to provide four nameservers..so that should change. I do agree that it should ask the parent to do the update, I'll see what I can do this morning.