search

Hadron / carthage-aws

AWS Plugin for Carthage
Other
2 stars 2 forks source link

Added contains, reworked update_record, modified DnsManagement to use contains #6

Closed srak289 closed 2 years ago

srak289 commented 2 years ago

This would also allow A records to be updated en masse as opposed to individual API calls. Possibly using some future function like zone.update_records(collect_host_records)

hartmans commented 2 years ago

I agree with permitting values to be a list. But why do we want update_record to take a tuple? It doesn't reduce the number of api calls or anything. Why not just have the caller call update_record multiple times?

srak289 commented 2 years ago

Unless I'm mistaken it directly reduces the number of API calls.

Calling update_record with multiple tuples appends a dict for each record tuple, to changes(list), which is then used in the single call to change_resource_record_set where changes is used as the list of changes to make.