Closed neil-glikin closed 1 year ago
Format check will fail; I think we should get rid of this for now, since it does a few undesirable things, for example spacing around math operators and spacing around the =
in keyword arguments.
Base: 91.5% // Head: 88.5% // Decreases project coverage by -3.0%
:warning:
Coverage data is based on head (
f6f9e1c
) compared to base (9df6d9e
). Patch coverage: 80.7% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
update docs
Broadly gives IonSim a more "functional" programming feel.
Some major changes:
chamber.iontrap.ions
, we call should callions(chamber)
.!
at the end of the function name. Setter functions always take in the object that's being modified as the first argument.)Trap
->Chamber
IonConfiguration
->IonTrap
stark_shift
->manualshift
vibrational_modes
->selectedmodes
Some minor changes:
timescale
inhamiltonian
changed from 1e-6 to 1 (however, there is a problem whentimescale=1
is actually used; see #104)LinearChain
constructorIon
s to be constructed with sublevel aliasesChamber
and aLaser
and/orIon
to optionally index theLaser
/Ion
with anInt