Open psktam opened 1 year ago
Ah sorry @marwahaha ; didn't mean to tag you as a reviewer; it was a fat-finger, and it doesn't seem like I can remove you. Feel free to review or not review as you please.
Patch coverage: 94.0
% and project coverage change: +5.4
:tada:
Comparison is base (
3bbdce9
) 83.5% compared to head (2861498
) 88.8%.:exclamation: Current head 2861498 differs from pull request most recent head 4892a28. Consider uploading reports for the commit 4892a28 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Have some convenient shorthand for loadfromconfig("../configs/ions/[ionname].yaml")
to be able to easily load properties of predefined ion species
Have some convenient shorthand for
loadfromconfig("../configs/ions/[ionname].yaml")
to be able to easily load properties of predefined ion species
I think this is ready to merge once this is done.
Summary:
IonInstance
class. We now directly instantiateIon
IonProperties
and config file functions to their own file, as it felt likeions.jl
was getting too big.