HaeffnerLab / IonSim.jl

a simple tool for simulating trapped ion systems
https://ionsim.org
MIT License
70 stars 17 forks source link

Adding config-style definitions for ion species properties #109

Open psktam opened 1 year ago

psktam commented 1 year ago

Summary:

psktam commented 1 year ago

Ah sorry @marwahaha ; didn't mean to tag you as a reviewer; it was a fat-finger, and it doesn't seem like I can remove you. Feel free to review or not review as you please.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.0% and project coverage change: +5.4 :tada:

Comparison is base (3bbdce9) 83.5% compared to head (2861498) 88.8%.

:exclamation: Current head 2861498 differs from pull request most recent head 4892a28. Consider uploading reports for the commit 4892a28 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #109 +/- ## ======================================== + Coverage 83.5% 88.8% +5.4% ======================================== Files 15 13 -2 Lines 1488 1270 -218 ======================================== - Hits 1242 1128 -114 + Misses 246 142 -104 ``` | [Impacted Files](https://codecov.io/gh/HaeffnerLab/IonSim.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab) | Coverage Δ | | |---|---|---| | [src/IonSim.jl](https://codecov.io/gh/HaeffnerLab/IonSim.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab#diff-c3JjL0lvblNpbS5qbA==) | `100.0% <ø> (ø)` | | | [src/ions.jl](https://codecov.io/gh/HaeffnerLab/IonSim.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab#diff-c3JjL2lvbnMuamw=) | `87.8% <84.6%> (+1.5%)` | :arrow_up: | | [src/ionproperties.jl](https://codecov.io/gh/HaeffnerLab/IonSim.jl/pull/109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab#diff-c3JjL2lvbnByb3BlcnRpZXMuamw=) | `97.3% <97.3%> (ø)` | | ... and [7 files with indirect coverage changes](https://codecov.io/gh/HaeffnerLab/IonSim.jl/pull/109/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HaeffnerLab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

neil-glikin commented 1 year ago

Have some convenient shorthand for loadfromconfig("../configs/ions/[ionname].yaml") to be able to easily load properties of predefined ion species

jbroz11 commented 1 year ago

Have some convenient shorthand for loadfromconfig("../configs/ions/[ionname].yaml") to be able to easily load properties of predefined ion species

I think this is ready to merge once this is done.