HaeffnerLab / IonSim.jl

a simple tool for simulating trapped ion systems
https://ionsim.org
MIT License
71 stars 17 forks source link

Update hamiltonians.jl #52

Closed marwahaha closed 1 year ago

marwahaha commented 2 years ago

I made a number of comments to hamiltonians.jl .

My main comments are:

codecov[bot] commented 2 years ago

Codecov Report

Merging #52 (1983cba) into master (4630f9d) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   97.09%   97.09%           
=======================================
  Files          11       11           
  Lines         964      964           
=======================================
  Hits          936      936           
  Misses         28       28           
Impacted Files Coverage Δ
src/hamiltonians.jl 93.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4630f9d...1983cba. Read the comment docs.

jbroz11 commented 1 year ago

We will be changing this code a bit when we add in arb rotating frame transformation capability, so this is no longer relevant.