HaeffnerLab / IonSim.jl

a simple tool for simulating trapped ion systems
https://ionsim.org
MIT License
70 stars 17 forks source link

Add Be and Mg species #84

Closed neil-glikin closed 2 years ago

neil-glikin commented 2 years ago

Changes: add src/species/be9.jl, add src/species/mg25.jl, modify src/species/_include_species.jl

codecov[bot] commented 2 years ago

Codecov Report

Merging #84 (14c3ccd) into master (05bac1d) will decrease coverage by 1.8%. The diff coverage is 33.3%.

@@           Coverage Diff            @@
##           master     #84     +/-   ##
========================================
- Coverage    85.1%   83.3%   -1.8%     
========================================
  Files          13      15      +2     
  Lines        1163    1199     +36     
========================================
+ Hits          990     999      +9     
- Misses        173     200     +27     
Impacted Files Coverage Δ
src/species/be9.jl 33.3% <33.3%> (ø)
src/species/mg25.jl 33.3% <33.3%> (ø)
src/operators.jl 86.6% <0.0%> (-2.1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05bac1d...14c3ccd. Read the comment docs.

jbroz11 commented 2 years ago

The way the information described for different ion species is processed is common and should be handled the same, but we should add tests that iterate through available ion species and ensure there aren't basic syntax errors (which I imagine are easy to make). Maybe just checking that we can instantiate an ion of every species would be enough.

neil-glikin commented 2 years ago

The tests as of now do try to instantiate an ion of every species (though this is as far as they go).