Closed marwahaha closed 2 years ago
Merging #91 (69ecbee) into master (adf0657) will increase coverage by
0.1%
. The diff coverage is100.0%
.
@@ Coverage Diff @@
## master #91 +/- ##
========================================
+ Coverage 89.5% 89.7% +0.1%
========================================
Files 15 15
Lines 1166 1170 +4
========================================
+ Hits 1044 1049 +5
+ Misses 122 121 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/ion_configurations.jl | 100.0% <100.0%> (ø) |
|
src/operators.jl | 89.4% <0.0%> (+0.7%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update adf0657...69ecbee. Read the comment docs.
Now that I think about this I realize I'm a little confused. We define the strength of the confining potential by its COM frequency; but two homogeneous ion chains of two different masses will have two different COM frequencies. So, is there even necessarily a well-defined COM mode for a heterogeneous chain? If so then we're fine, but if not, then com_frequencies
is not meaningful in the first place.
To clarify, I think (without looking at it more yet) your work is probably valid assuming that the mass of the first ion defines the strength of the trapping potential: $V(x) = \tfrac12m_1\nu^2x^2$ where $\nu$ is the parameter given as one of the com_frequencies
. The open question as I see it right now is one of how we parametrize things from the user's perspective; should they parameterize it in terms of the first ion, or in terms of the actual lowest-frequency in-phase mode of the chain?
Here's another source I just found: https://link.springer.com/content/pdf/10.1007/s100530170275.pdf
@marwahaha actually have an almost fully working version of this on a local branch atm. Was waiting on finishing an example before posting. Sorry, didn't realize anyone else was working on it.
I did have the same thing for the equilibrium positions.
@neil-glikin The frequencies are a feature of the pseudo potential. The fact that they correspond to com frequencies when all masses are equal is a secondary point. IMO we should continue to quantify them the same way and then update the terminology or maybe clarify in relevant doc strings.
To clarify, my point isn't about when modes do and don't correspond to true center-of-mass motion. The frequencies aren't just a feature of the pseudo-potential; they also depend on the mass. A single ion in a given pseudo-potential will have a different frequency depending on its mass. This means that there is an ambiguity in the meaning of com_frequencies
given heterogeneous chains (irrespective of whether or not they correspond to true center-of-mass motion). We need to specify the pseudo-potential, but a frequency alone isn't enough.
I see what you're saying now. Also, I didn't include this effect in my work so far.. I guess we can discuss a convention today at the meeting (like maximum mass or maybe the mass of the first ion in the chain). Shouldn't matter too much as long as we clarify in the docs.
And it seems like here at least, they just specify by the actual com motion of the mixed chain. That probably makes the most sense.
Closing this based on Neil's observation.
Please double check my work.
I rederived from the reference linked, and it looks like if $\ell = \ell_1$, then the first $u_m$ term is offset by a factor of $M_m/M_1$.
It seems to work, but I have some questions: