Haehnchen / idea-php-phpunit-plugin

IntelliJ IDEA / PhpStorm PHPUnit Enhancement Plugin
MIT License
55 stars 11 forks source link

Disable gutter icons starting from PhpStorm 2018.1 #33

Closed wbars closed 4 years ago

wbars commented 6 years ago

Hello!

We are going to implement gutter icons for the PHPUnit tests as part of this ticket, so you may consider to disable your implementation starting from ticket fix version (which will be one of the 2018.1 EAP versions).

scaytrase commented 6 years ago

Yes, really annoying since release, but disabling plugin gets more drawbacks, so we have to deal with to two arrows working differently

mekras commented 6 years ago

I am using both icons because native PHPStorm icon creates new run configuration, and plugin icon runs test without creating configuration. It is handy when you just want to be sure that some test is not broken.

King2500 commented 6 years ago

The native one should provide both possibilities:

Left click: run directly. Right click: show menu with different run options (normal, debug, coverage) and create appropriate run config.

wbars commented 6 years ago

@mekras @King2500 Hi, could you please elaborate why creating new run configuration while running the test is bad thing? It will be not persisted if you don't want to and it will be vanished when number of tmp configurations will surpass the threshold.

mekras commented 6 years ago

@wbars,

It will be not persisted if you don't want

Currently it will be persisted. And worse, when switching between tasks, it can fall into the configuration lists in other tasks. Now I have to delete these configurations manually. The idea-php-phpunit-plugin implementation lacks these drawbacks.

Haehnchen commented 4 years ago

feature removed from plugin