search

Haehnchen / idea-php-toolbox

Collections of tools and improvements to make PhpStorm a little bit better
http://phpstorm.espend.de/php-toolbox
MIT License
158 stars 20 forks source link

com.sun.net.httpserver.HttpServer is not part of java.base module (java9+ issue) #86

Open VISTALL opened 5 years ago

VISTALL commented 5 years ago

Hello.

There a problem with this code https://github.com/Haehnchen/idea-php-toolbox/blob/master/src/main/java/de/espend/idea/php/toolbox/remote/RemoteListenerComponent.java#L19

HttpServer is is not part java.base module. It's not even public API. (for now it's compiled and running without problem - but internal api is internal api)

Maybe use built-in server for this implementation (org.jetbrains.io.BuiltInServer) ? Or write new via netty?