HagesLab / OneLayer

One-layer transient PL simulations, but in runnable application form
GNU General Public License v3.0
0 stars 0 forks source link

Batch generation tool issue when disabling steady state input flag #27

Open rwmacq opened 3 years ago

rwmacq commented 3 years ago

Noticed an issue relating to batch generation. After performing batch processes relating to 'power' as the batch input parameter with the steady state input flag selected, I disable the steady state input flag and attempt to generate a new batch, again relating to 'power', to simulate TRPL measurements of the same material system. I noticed that under these conditions, the batch tool generates a set of initial conditions files that are all the same, rather than generating new excitation conditions for each power value input in the batch tool, using the last value of 'power' input in the batch tool. I can also see that the program isn't calculating excitation conditions for each power selected, but instantaneously creates the full set of initial conditions files (rather than working through each power and calculating delta_N, etc., which is something I can normally see occurring in real time).

I assume this has something to do with the steady state input flag being deactivated. When I restart TEDs and load an initial conditions file that was generated with the steady state input flag selected, then I deactivate it and attempt batch generation, the same issue occurs. So it seems to relate to the initial conditions file, or the program's handling of them, and in some way concerns the steady state flag. I haven't attempted to debug this extensively, but it's cropped up a few times now so it's reproducible in some sense. My current workaround is restart TEDs and manually re-enter the material parameters from the steady state initial conditions file, which works fine but is a little bit more work. I'm interested to see if anyone else can reproduce the bug.

rwmacq commented 3 years ago

I've just found that if one manually regenerates the initial excitation conditions after disabling the steady state flag, and inputting a pulse frequency, then this issue is avoided. So I don't know if this counts as a bug, or just something that could be made more user-friendly.