search

HagesLab / OneLayer

One-layer transient PL simulations, but in runnable application form
GNU General Public License v3.0
0 stars 0 forks source link

breaking up main into parts in notebook module #35

Closed eistrup closed 2 years ago

eistrup commented 2 years ago

The script main.py has 4600 lines of code, making it very hard to work with it.

I suggest breaking up the construction of the Notebook object into separate scripts, trying to make a senseful class inheritance and/or method imports.

It would be very useful to have the responsabilities divided into their scripts/classes/layers: main.py -> only instantiates and runs the Notebook Notebook() -> class with the methods interesting to execution of the Notebook BaseNotebook() -> class with all instantiation and preparation of the Notebook ... possibly further dividing methods and scripts

cfai2304 commented 2 years ago

This branch's notebook.py incorporates several changes from seq_charge_transfer - it would be easier at this point to merge seq_charge_transfer into master first and then re-apply the principles noted here to the updated main.py