Haian-Jin / TensoIR

[CVPR 2023] TensoIR: Tensorial Inverse Rendering
https://haian-jin.github.io/TensoIR/
MIT License
237 stars 12 forks source link

Question about the rescale ratio for diffuse color #16

Closed mush881212 closed 9 months ago

mush881212 commented 1 year ago

Hi,

I am a student with a keen interest in the topic at hand. While exploring your repository, I came across the "relight_importance.py" script and noticed the presence of a "compute_rescale_ratio" function. It appears that this computed ratio is intended for the purpose of rescaling the diffuse color. I am curious to understand the specific rationale behind this rescaling process. In my view, it might be possible to achieve the desired relighting results using the original, unaltered diffuse color.

Thanks for your amazing work and look forward to your reply.

Haian-Jin commented 1 year ago

Hi, We follow what has been done in NeRFactor, i.e. when visualizing and measuring the reconstructed albedo, we will compute and use a global factor to rescale the albedo reconstruction results.

Please check the Sec. 4.2 of NeRFactor's paper for more details.