Api Error `Job {...} does not exist` should not count as a fault for the purpose of `_consecutive_failed_jobs`

Haidra-Org / horde-worker-reGen

The default client software to create images for the AI-Horde

https://aihorde.net/

GNU Affero General Public License v3.0

94 stars 42 forks source link

Api Error `Job {...} does not exist` should not count as a fault for the purpose of `_consecutive_failed_jobs` #255

Open tazlin opened 3 months ago

tazlin commented 3 months ago

By incrementing ._consecutive_failed_jobs for this error, the worker will erroneously pause popping jobs. As this error does not indicate poor conditions on the worker (and is in fact a race-condition API-side to do with the database) it is incorrect to consider this error a form of fault/failed job.