Fix Documentation path & change button label

HaikuArchives / ArmyKnife

ArmyKnife is an application that lets you edit the metadata of audio files

MIT License

6 stars 14 forks source link

Fix Documentation path & change button label #39

Closed BachToTheFuture closed 6 years ago

BachToTheFuture commented 6 years ago

This PR:

fixes #20: The "Apply" button is now "Save" to avoid confusion.
fixes #22: replaced B_APPS_DIRECTORY with a combo of GetActiveAppInfo, GetPath, and GetParent (learned these from "Filer" 😀 ) so that the program could get to its docs relatively.

BachToTheFuture commented 6 years ago

I tested this on x86_64, and it works flawlessly 🎊 Changed srcGitRev and checksum to my commit, and the recipe builds like it should 😄 . I installed and ran ArmyKnife, and...

the Apply button is now Save, so I guess that's good.
the Readme and the Changelog HTML docs seem to be working okay.

I don't know if this will work if installed in the "Home" hierarchy, as @humdingerb suggested.

humdingerb commented 6 years ago

I don't know if this will work if installed in the "Home" hierarchy

@bach5000 , it should. If you want to test, remove your package from /system/packages/ and move it into /boot/home/config/packages/ instead. Now ArmyKnifw appears in /boot/home/config/apps/

scottmc commented 6 years ago

It failed for me when just simply running make and then trying to run the binary. Wasn't able to find it in home/armyknife/documentation/armyknife I think it was. But if it works in system/packages and home/config/packages that is acceptable.

ddacw commented 6 years ago

Thanks @bach5000 for finishing the help menu, as I intended to continue with this...

humdingerb commented 6 years ago

I just changed the paths for the readme and changelog. Shouldn't have been in another "armyknife" subfolder. The recipe will have to be slightly altered to add the changelog. Guess we'll wait to fter GCI for that.

BachToTheFuture commented 6 years ago

@eddrda No problem 😉 Glad to help (although I forgot to ask you if you wanted to continue)

scottmc commented 6 years ago

If anyone is interested, perhaps after GCI ends... The changelog needs to be updated. This will require reviewing the changes made since it was first moved to osdrawer years ago. But that should be covered in the commits history.