Clang static analysis

[Vidrep]

Since ArtPaint is getting some recent love, I thought I'd run the Clang static analysis on the code and provide the report here scan-build-2022-04-08-ArtPaint.zip in case there are a few real bugs amongst the false positives.

[dsizzle]

ooh nice, thank you!

[Vidrep]

Here's a zip of the Clang Static Analysis for most recent build I did (June 17, 2022) scan-build-2022-06-17.zip

[dsizzle]

Thanks @Vidrep - I have a couple of changes queued up from last time but I appreciate a more up to date report!

[Vidrep]

After the last batch of commits, the number of bugs found by Clang has dropped from 272 to 206. Here's the latest report. scan-build-2022-06-19.zip

[Vidrep]

We've gone from 206 bugs down to 90. Here's the most recent report. scan-build-2022-06-26.zip

[Vidrep]

From 90 to 58 bugs as of most recent report (attached). scan-build-2022-07-02.zip

[Vidrep]

Here's a clang static analysis build for the latest commit to ArtPaint. Reported bugs - 67. Up from 58 last time. scan-build-2022-09-25.zip

[Vidrep]

Attached is a clang static analysis as of October 2. Bugs found has dropped from 58 to 49. scan-build-2022-10-02.zip

[Vidrep]

Attached a clang static analysis report Nov 20. Bugs found - 57 scan-build-2022-11-20.zip

[dsizzle]

Thanks @Vidrep - I fixed several items, but for the most part the rest of these items are not real issues. I wouldn't call them "bugs."

[Vidrep]

I have attached a clang static analysis zip file for the latest build (March 20, 2023) 60 issues found scan-build-2023-03-20.zip

[Vidrep]

It's been 6 months since my last clang static analysis. For what it's worth, the number of issues is now 84. scan-build-2023-09-19.zip

[dsizzle]

Thanks @Vidrep ! I fixed a bunch of the issues - I always appreciate these reports.

[Vidrep]

Here's one from today Oct 11, 2023 scan-build-2023-10-11.zip

[Vidrep]

Here's your monthly scan ;) 49 issues found. Hope it helps somehow scan-build-2023-11-10.zip

[dsizzle]

@Vidrep, it's very helpful. While there are a number of "false-positives" where clang doesn't quite understand the code, it's definitely beneficial for seeing things I might have missed in code that I changed recently. Particularly with larger code changes, these reports always point out something that should be fixed before release. Thanks!

[humdingerb]

Thanks @Vidrep ! Could you quickly explain how you create these scans, step-by-step. I'd like to try those for other projects. Here, via personal email or forum post, whatever you prefer.

[Vidrep]

Thanks @Vidrep ! Could you quickly explain how you create these scans, step-by-step. I'd like to try those for other projects. Here, via personal email or forum post, whatever you prefer.

Hey humdinger! Sorry for not responding sooner.

Install llvm_clang_analysis and dependencies (usually llvm_clang and llvm**_libs)

To run a scan, simply open a terminal and enter "scan-build make" (or in the case of Artpaint "build.sh") You'll find the html report in your system cache folder once it's complete.

[humdingerb]

Thanks, @Vidrep, that's easy enough. :)