HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.
https://haikuarchives.github.io/ArtPaint/
29 stars 18 forks source link

ScaleManipulator: register undo when selection/layer is translated #494

Closed dsizzle closed 1 year ago

dsizzle commented 1 year ago

Fixes #493

I didn't update canvas resize, because a pure translate in that case really is nothing.

humdingerb commented 1 year ago

Something's wrong. One time it crashed: ArtPaint-15093-debug-19-03-2023-19-02-11.report.txt

Plus:

dsizzle commented 1 year ago

is this better?

humdingerb commented 1 year ago

I'm afraid not... See for example:

https://user-images.githubusercontent.com/6107158/226387868-0e5a5f21-1e66-44b0-8399-95cca71d18fa.mp4

Hope that clip works...

Easy to reproduce:

dsizzle commented 1 year ago

The clip doesn't work. I also can't reproduce:

ALT+E, move down and left, partially outside canvas: 01trans

Undo (or ALT+Z): 03trans

No issue: 02trans

Same thing with a selection. Can you try uploading a different video?

humdingerb commented 1 year ago

Terribly sorry, I seem to have not used the latest build when trying yesterday. Or it only works on odd days... :} Anyway, the fix is good. And we merge...

dsizzle commented 1 year ago

hahaha, no worries at all. It wouldn't be the first time I couldn't reproduce something. Also sometimes these "easy" ones turn out to be quite difficult - so I don't judge. Thanks!