HaikuArchives / ArtPaint

ArtPaint is a painting and image processing program.
https://haikuarchives.github.io/ArtPaint/
29 stars 18 forks source link

BrushStore: move brush editor from Brush tool settings to store window #501

Closed dsizzle closed 1 year ago

dsizzle commented 1 year ago

part of #202

EDIT: also realized I should gray out the "Size" slider when "Use current brush" is selected.

humdingerb commented 1 year ago

also realized I should gray out the "Size" slider when "Use current brush" is selected.

Yes. Either that, or use both option as radio buttons instead of the checkmark. [Edited: would improve alignment of the two rows, I imagine.] One issue I found: If you "Use current brush" and select a saved brush, nothing seems to be drawn. Only if you "Reset brush", stuff gets drawn.

Possibly difficult to do, since it's a layouting detail, but could the brush preview frame in the status bar merge at the top and bottom with the status bar border? Otherwise it appears like a thick stroke:

screenshot1

Nice change! But Oh noes!, now we either need to come up with another tool or remove a second tool, so I can have two columns without a tool-gap... :)

dsizzle commented 1 year ago

One issue I found: If you "Use current brush" and select a saved brush, nothing seems to be drawn. Only if you "Reset brush", stuff gets drawn.

oops. You are correct. In fact any change to the brush (not just 'reset') made drawing work. Anyway, I fixed the issue and pushed it.

but could the brush preview frame in the status bar merge at the top and bottom with the status bar border?

you and that magnifying glass again. I think I can resize the preview - not sure if I can make it larger to blend with the upper/lower edges, but I can probably make it smaller so there's at least a little border?

humdingerb commented 1 year ago

you and that magnifying glass again.

Heh. One of my pet peeves. :) Fat lines kinda stand out to me even non-magnified. I just include a Mag-shot to see it clearer and to be able to count pixels.

I think I can resize the preview - not sure if I can make it larger to blend with the upper/lower edges, but I can probably make it smaller so there's at least a little border?

Yeah, maybe aligned to the colour swatches beside it, so 3 pixels.

dsizzle commented 1 year ago

on my screen it was only 2 pixels, so I made it match the color swatch. There's a bit of a visual difference since the color swatch has a white border, but it does match size-wise now.

humdingerb commented 1 year ago

Very good! Merge!